linuxserver
drop2beets implementation
Drop2beets requires more dependencies than can be included by just dropping in the plugin file. It also seems pretty usefull as it allows the container to run more as a daemon (moving all incoming files under /downloads).
- [x] I have read the contributing guideline and understand that I have made the correct modifications
Description:
Drop2beets is a plugin that allows beet to scan a folder and automatically move any files that come into it to the library. It's got some requirements (i think the package is called watchdog) that doesn't come normally on the container.
I've fixed this on my local version fine (execing into the container and running a pip install), but it would maybe be beneficial to include this plugin in the main container since i believe it is in the "spirit" of containers/services (not the strongest argument but well. it's all i got :) )
I did my best to implement it as best as i can without any major changes. added 1 extra package to the pip install at the start, also added an extra run command to make /downloads exist at runtime (since that is what i've set drop2beet to scan for by default)
I've modified the startup script to only run the plugin if the env var DROP_ENABLED is set (any value).
Unfortunately i did have to rewrite the config file a bit. Drop2beet works best with move enabled as opposed to copy so i did change that. I didn't want to assume what way the project would prefer to "template"/edit these config files on launch depending on the parameters, but i'm willing to implement it so it works just like it did before my changes.
Also this is the first time i've ever made a pull request. I'm doing my best o7
Benefits of this PR and context:
It does not fix a bug, however it does allow users another capability of running the container as a service by itself, automatically letting it import tracks that are placed under /downloads into it's library which i personally deem as beneficial and assume others will aswell.
How Has This Been Tested?
I build the dockerfile using podman, using some trial and error testing with modifying the startup script under root/etc/s6-overlay/s6-rc.d/svc-beets/run until i got the plugin to start up only when giving the env var and having it not halt any other parts of the script (web service still starts up)
I admit, i don't really understand what s6-notifyoncheck does, but adding it stopped the rest of the stuff from proceeding. so i just used a & sign to start the plugin in the background
Source / References:
the link to the drop2beets project: https://github.com/martinkirch/drop2beets/tree/master
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.3.1-pkg-832e44ee-dev-51dfc41b50c72ea20dc07b3bfc073ce0c45c34c9-pr-138/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.3.1-pkg-832e44ee-dev-51dfc41b50c72ea20dc07b3bfc073ce0c45c34c9-pr-138/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.3.1-pkg-832e44ee-dev-51dfc41b50c72ea20dc07b3bfc073ce0c45c34c9-pr-138 | ✅ |
| arm64v8-2.3.1-pkg-832e44ee-dev-51dfc41b50c72ea20dc07b3bfc073ce0c45c34c9-pr-138 | ✅ |
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.3.1-pkg-a51495dd-dev-0bbd0c73205b499ff4cf865186c38ed3ca63d37d-pr-138/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.3.1-pkg-a51495dd-dev-0bbd0c73205b499ff4cf865186c38ed3ca63d37d-pr-138/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.3.1-pkg-a51495dd-dev-0bbd0c73205b499ff4cf865186c38ed3ca63d37d-pr-138 | ✅ |
| arm64v8-2.3.1-pkg-a51495dd-dev-0bbd0c73205b499ff4cf865186c38ed3ca63d37d-pr-138 | ✅ |
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.4.0-pkg-aa56b45d-dev-40e12424b31d294ff2fb1c3997c61854cf8a1d14-pr-138/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.4.0-pkg-aa56b45d-dev-40e12424b31d294ff2fb1c3997c61854cf8a1d14-pr-138/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.4.0-pkg-aa56b45d-dev-40e12424b31d294ff2fb1c3997c61854cf8a1d14-pr-138 | ✅ |
| arm64v8-2.4.0-pkg-aa56b45d-dev-40e12424b31d294ff2fb1c3997c61854cf8a1d14-pr-138 | ✅ |
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-504efe8b-dev-0e38b0cbda139dfd4e760cf57160b63afd2dee17-pr-138/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-504efe8b-dev-0e38b0cbda139dfd4e760cf57160b63afd2dee17-pr-138/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.5.1-pkg-504efe8b-dev-0e38b0cbda139dfd4e760cf57160b63afd2dee17-pr-138 | ✅ |
| arm64v8-2.5.1-pkg-504efe8b-dev-0e38b0cbda139dfd4e760cf57160b63afd2dee17-pr-138 | ✅ |
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-9b0a8e6d-dev-968d8df5cccedd1783c2e7bd2688e9428a0b42b8-pr-138/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-9b0a8e6d-dev-968d8df5cccedd1783c2e7bd2688e9428a0b42b8-pr-138/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.5.1-pkg-9b0a8e6d-dev-968d8df5cccedd1783c2e7bd2688e9428a0b42b8-pr-138 | ✅ |
| arm64v8-2.5.1-pkg-9b0a8e6d-dev-968d8df5cccedd1783c2e7bd2688e9428a0b42b8-pr-138 | ✅ |
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-9406504f-dev-892e7f13da34779c0d2e544272f2865cba09ed62-pr-138/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-9406504f-dev-892e7f13da34779c0d2e544272f2865cba09ed62-pr-138/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.5.1-pkg-9406504f-dev-892e7f13da34779c0d2e544272f2865cba09ed62-pr-138 | ✅ |
| arm64v8-2.5.1-pkg-9406504f-dev-892e7f13da34779c0d2e544272f2865cba09ed62-pr-138 | ✅ |
is there a reason you can't simply use https://github.com/linuxserver/docker-mods/tree/universal-package-install to install drop2beets like other users have? I'm not sure why we need to force new packages on users that may not want it
is there a reason you can't simply use https://github.com/linuxserver/docker-mods/tree/universal-package-install to install drop2beets like other users have? I'm not sure why we need to force new packages on users that may not want it
I didn't knew this was a thing. I've changed my PR #142. If you want to merge this one instead let me know so I'll drop it in my PR.
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-8345e7e8-dev-ad28e38aa1d66f73f11081d06c835593e49ece0b-pr-138/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-8345e7e8-dev-ad28e38aa1d66f73f11081d06c835593e49ece0b-pr-138/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.5.1-pkg-8345e7e8-dev-ad28e38aa1d66f73f11081d06c835593e49ece0b-pr-138 | ✅ |
| arm64v8-2.5.1-pkg-8345e7e8-dev-ad28e38aa1d66f73f11081d06c835593e49ece0b-pr-138 | ✅ |
is there a reason you can't simply use https://github.com/linuxserver/docker-mods/tree/universal-package-install to install drop2beets like other users have? I'm not sure why we need to force new packages on users that may not want it
You actually need the s6 service at least. And there's no way to mod the image to add a proper s6 service for drop2beets. Is there any way to get #142 reviewed and merged some day?
Is there any way to get #142 reviewed and merged some day?
when one of the team members that uses this project gets time to look at it