linuxfr.org icon indicating copy to clipboard operation
linuxfr.org copied to clipboard

fix multiple sharp signs in URIs

Open Trim opened this issue 3 years ago • 3 comments

rename HttpUrlValidator as UriValidator

Suivi: https://linuxfr.org/suivi/impossible-de-mettre-un-lien-vers-un-salon-matrix-dans-les-liens-d-une-depeche

Trim avatar Jan 07 '23 17:01 Trim

Beware of the invisible merge conflict with #355: the change won't cause a conflict but it won't work due to renaming the validator.

nud avatar Jan 08 '23 21:01 nud

Beware of the invisible merge conflict with #355: the change won't cause a conflict but it won't work due to renaming the validator.

Indeed, I've just merged #355 in the current PR so @Oumph will just need to merge this one as the conflict is resolved.

I've just added commits to add an after_validation method too, to revert the workaround with the sharp sign before saving data inside the database. So user input will match with the data saved and visually the user will not be confused with the %23 encoding.

Trim avatar Jan 28 '23 22:01 Trim

@Trim given that #355 was trivial and that this one doesn't show any sign of being merged, wouldn't it be easier to at least fix the existing bug by merging #355 first? Or would you merge this one?

nud avatar Mar 06 '24 22:03 nud