dde-session-shell icon indicating copy to clipboard operation
dde-session-shell copied to clipboard

fix: Respect CMAKE_INSTALL_LIBDIR for module installation and lookup

Open hillwoodroc opened this issue 4 months ago • 3 comments

This ensures correct installation and runtime lookup on both lib and lib64 based systems.

Log:

  • Define CMAKE_INSTALL_FULL_LIBDIR in top-level CMakeLists.txt
  • Replace hardcoded 'lib/dde-session-shell/modules' with '${CMAKE_INSTALL_LIBDIR}/dde-session-shell/modules' in all plugin CMakeLists
  • Update modules_loader.cpp to use CMAKE_INSTALL_FULL_LIBDIR for locating modules and configs

hillwoodroc avatar Sep 18 '25 13:09 hillwoodroc

Hi @hillwoodroc. Thanks for your PR. :smiley:

deepin-ci-robot avatar Sep 18 '25 13:09 deepin-ci-robot

Hi @hillwoodroc. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deepin-ci-robot avatar Sep 18 '25 13:09 deepin-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hillwoodroc, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Sep 19 '25 01:09 deepin-ci-robot