dde-file-manager icon indicating copy to clipboard operation
dde-file-manager copied to clipboard

fix: [254647/dock] device list might be shorten

Open itsXuSt opened this issue 1 year ago • 1 comments

use resize to adjust the size of device list.

Log: as title.

Bug: https://pms.uniontech.com/bug-view-254647.html

itsXuSt avatar May 13 '24 09:05 itsXuSt

deepin pr auto review

关键摘要:

  • DeviceList类的showEvent函数中,调用setFixedHeight被替换为resize,可能会影响窗口的布局和响应式设计。
  • 移除了showEvent的访问修饰符,如果其他类需要访问showEvent逻辑,可能会导致封装破坏。

是否建议立即修改:

  • 是,应该评估resizesetFixedHeight的使用场景,确保它们的行为一致并且不会破坏现有的布局和响应式设计。
  • 是,如果showEvent是类的重要逻辑,不应该轻易移除访问修饰符,以避免潜在的封装破坏。

deepin-ci-robot avatar May 13 '24 09:05 deepin-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar May 17 '24 01:05 deepin-ci-robot

/merge

itsXuSt avatar May 20 '24 07:05 itsXuSt