dde-file-manager icon indicating copy to clipboard operation
dde-file-manager copied to clipboard

fix: [computer]Getting the UUID is stuck, causing the interface to freeze

Open pengfeixx opened this issue 1 year ago • 3 comments

Put the obtained UUID into the thread for execution

Log: Fixed some known issues Bug: https://pms.uniontech.com/bug-view-254659.html

pengfeixx avatar May 13 '24 05:05 pengfeixx

/retest

pengfeixx avatar May 13 '24 05:05 pengfeixx

deepin pr auto review

关键摘要:

  • asyncQueryBlockInfoasyncQueryProtocolInfo函数中,使用QtConcurrent::run替代手动处理的线程。
  • asyncQueryInfo函数中使用了FinallyUtil来确保在函数执行完成后执行清理操作。
  • exit变量在ComputerView的构造函数中被设置为false,但在析构函数中没有被使用。
  • handleDisksVisiblehandleComputerItemVisible函数中添加了对dp->exit的检查,但是在ComputerView的析构函数中没有看到对exit变量的处理。

是否建议立即修改:

建议的修改:

  • ComputerView的析构函数中添加对exit变量的处理,确保在退出时能够正确地清理资源。
  • 检查asyncQueryInfo函数中的FinallyUtil是否确实需要,因为QtConcurrent::run已经提供了自动清理线程的功能。
  • 确认exit变量在ComputerView中的用途,如果不需要,应该在构造函数中将其设置为true,以确保在构造函数中就退出。

deepin-ci-robot avatar Jun 06 '24 07:06 deepin-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Jun 06 '24 07:06 deepin-ci-robot

/merge

pengfeixx avatar Jun 06 '24 08:06 pengfeixx