manager icon indicating copy to clipboard operation
manager copied to clipboard

M3-5814: Refactors in SelectPlanPanel.tsx / DatabaseCreate.tsx

Open codyfinn opened this issue 3 years ago • 1 comments

Description

Moves the logic for calculating the prices for different DB cluster plans back to the DatabaseCreate component. In addition this PR establishes a new PlanSelectionType to help standardized the data used to select form different plans. I think more can be done with this but the current iteration is a good first step. I think due to the widespread use of the SelectPlanPanel it could be extracted from the LinodeCreate structure and generalized to make it easier to possibly create more custom plan selections in the future for new products.

How to test

Ensure that creation flows for Linodes and Databases work as intended paying attention to pricing and copy. Also ensure that the Linode Resize flow has stayed the same paying close attention to pricing and copy.

codyfinn avatar May 25 '22 13:05 codyfinn

New changes look good. There's a failing test in GH, but when I run the DatabaseCreate tests locally they pass. Not sure why.. I just re-ran the job.

johnwcallahan avatar Jun 10 '22 14:06 johnwcallahan