cluster-api-provider-linode icon indicating copy to clipboard operation
cluster-api-provider-linode copied to clipboard

[CI]: create a test matrix based on template paths

Open eljohnson92 opened this issue 1 year ago • 2 comments

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

TODOs:

  • [ ] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests
  • [ ] adds or updates e2e tests

eljohnson92 avatar May 24 '24 16:05 eljohnson92

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.13%. Comparing base (869bcda) to head (0bc99ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   66.13%   66.13%           
=======================================
  Files          35       35           
  Lines        2179     2179           
=======================================
  Hits         1441     1441           
  Misses        676      676           
  Partials       62       62           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 16:05 codecov[bot]

LGTM :+1:

Are all of the flavours independent of one another, or would say the kubeadm_full flavour depend on the kubeadm "default" flavour?

nesv avatar May 24 '24 16:05 nesv

the flavors will inherit from the default of each k8s distro

eljohnson92 avatar May 24 '24 17:05 eljohnson92

Don't we need a change to the 'labels' in the chainsaw test files?

apiVersion: chainsaw.kyverno.io/v1alpha1
kind: Test
metadata:
  creationTimestamp: null
  name: minimal-linodemachine
  # Label to trigger the test on every PR
  labels:
    all:
    quick:
    linodemachine:

I believe with the new filters, the labels with not match these 3 above for example, and not get triggered.

amold1 avatar May 28 '24 12:05 amold1

the tests I was specifically targeting here are only the capl-cluster-flavors e2e tests, so the quick tests will always run, and then based on what templates change additional tests will run, right now the only paths that will actually trigger tests are templates/flavors/*/default but the way the matrix is set up it should also just work as we add more test coverage to other flavors

eljohnson92 avatar May 28 '24 14:05 eljohnson92