linkml-runtime icon indicating copy to clipboard operation
linkml-runtime copied to clipboard

Add action to test with upstream linkml v2

Open sneakers-the-rat opened this issue 1 year ago • 2 comments

Continues: https://github.com/linkml/linkml-runtime/pull/316

Sorry to keep doing this with CI actions - as far as I know I can't test them on the fork until they are in main?

The previous action wouldn't run because the dynamic versioning plugin can't detect version when run within a poetry shell - https://github.com/mtkennerly/poetry-dynamic-versioning?tab=readme-ov-file#caveats

you also apparently need to explicitly install the plugin.

so i modified it so that we create an arbitrarily high version with the commit hash appended to it so we can be sure that the current version is being installed rather than a cached version.

You can see that the action is running *but correctly failing due to https://github.com/linkml/linkml/issues/2047 * here - https://github.com/sneakers-the-rat/linkml-runtime/actions/runs/8531972641/job/23372442173

this should get squash merged, but wanted to preserve commit history in PR so it's possible to see the various options i tried. blah. one day this will all be done and our CI will be spic and span

sneakers-the-rat avatar Apr 03 '24 01:04 sneakers-the-rat

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.06%. Comparing base (0f99716) to head (8a5dee2). Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   62.70%   64.06%   +1.36%     
==========================================
  Files          63       63              
  Lines        8580     8611      +31     
  Branches     2444     2447       +3     
==========================================
+ Hits         5380     5517     +137     
+ Misses       2583     2477     -106     
  Partials      617      617              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 03 '24 01:04 codecov[bot]

Thinking about what we need for PRs like https://github.com/linkml/linkml-runtime/pull/314 - thats a change that also requires a change in upstream to pass ( https://github.com/linkml/linkml/pull/2032 ). Is it possible/should we add some input arguments that allow this to be run against a specific version of upstream? Like I know we can add arguments, but is there a way to make that sorta streamlined - like in the OP I put some line that links to the branch of upstream to test against.

The manual version would just be putting in username, repo name and branch, with defaults for all three, which is not too bad.

sneakers-the-rat avatar Apr 08 '24 15:04 sneakers-the-rat

Im p sure the most recent changes to the action are better than this lol

sneakers-the-rat avatar Jul 29 '24 18:07 sneakers-the-rat