parseq icon indicating copy to clipboard operation
parseq copied to clipboard

Proper logging for `withSafeSideEffect`

Open williamwjs opened this issue 3 years ago • 0 comments

In the below snippet, there's only try...catch logic to convert it to a failed task: https://github.com/linkedin/parseq/blob/74875ed2aa5deaaf5bf1ab822c2fe719039b4aa2/subprojects/parseq/src/main/java/com/linkedin/parseq/Task.java#L398-L408

However, it is hard to add logging on the caller side for this. Thus, the side effect may fail silently without an easy way to debug.

Could we use the LOGGER in this file to log the Throwable before line 407?

williamwjs avatar Nov 30 '22 18:11 williamwjs