norbert icon indicating copy to clipboard operation
norbert copied to clipboard

A couple of bug-fixes and a fail over capability for the partitioned client

Open nickhristov opened this issue 11 years ago • 3 comments

The first couple of commits are pure bug-fixes; I think they should be applied to the main project.

I also added a fail over capability to the partitioned load balancer client and a capability to work with non monotonically increasing partition identifiers (this is still being tested).

Protocol buffers was brought to a more recent version, 2.5.0 and the protocol files were re-generated.

nickhristov avatar Oct 28 '14 19:10 nickhristov

At this point, this pull request is not ready for merging into the main source line.

I did want to create and publish it, so that the LinkedIn team can have visibility into what's happening in my fork.

nickhristov avatar Oct 28 '14 19:10 nickhristov

One more thing which I want to mention here, since I cannot submit bug reports anywhere: graceful shutdown does not work properly in Norbert right now. I tried to play around with the shutdown code, but I was unable to fix the issue.

The problem appears to be the following: on shutdown the node marks itself offline. Once that happens further writes into the netty channel fail (so any ongoing requests on the node are not properly drained). Shutdown timeout does not work in this case either (I still see failures during testing).

nickhristov avatar Oct 28 '14 19:10 nickhristov

Thanks! Nick. I will take a look at it. It seems to me that your base of the changes are behind from the current code base. I think you can re-base your repository. Thanks, Joe

sungjuc avatar Oct 29 '14 06:10 sungjuc