dustjs icon indicating copy to clipboard operation
dustjs copied to clipboard

why is v3 a breaking change?

Open jpw opened this issue 4 years ago • 2 comments

Hi, thanks for releasing a new version.

Why is v3 a breaking change please? It's not clear to me from the changelog, and there is no migration guide. This would help us upgrade our apps. Thanks!

jpw avatar Jan 17 '22 10:01 jpw

https://github.com/linkedin/dustjs/commit/43c0831800657c8a8a3f5213d70107545d690937 seems like a breaking change.

sumeetkakkar avatar Jan 18 '22 01:01 sumeetkakkar

Thanks for your reply @sumeetkakkar !

Because I don't know how Dustjs works internally, I can't judge whether that is a breaking change or not. More importantly I cannot see what changes I might need to make in our apps to prevent them breaking when upgrading to v3. And that is what anyone upgrading would need to know. I hope that makes sense 🙂

Also I note that in this code comparison: https://github.com/linkedin/dustjs/compare/v2.7.5...v3.0.1 ...it looks like node 12 is the currently minimum supported version (which makes sense), I assume due to dependency updates? which would also be a breaking change.

jpw avatar Jan 18 '22 11:01 jpw