LiTr icon indicating copy to clipboard operation
LiTr copied to clipboard

Feature request: Group filters

Open janbolat opened this issue 4 years ago • 8 comments

Hi, Is there a way to apply multiple filters at once? For example, when I want to use 3 filters simultaneously:

TransformationOptions.Builder()
  .setVideoFilters(listOf(ContrastFilter(3f), BrightnessFilter(0.7f), SaturationFilter(0f)))

Only the last filter is applied to the transformation (target video) and previous ones are lost.

Does the library support it?

These examples GlFilterGroup, GlFilterGroup and GPUImageFilterGroup might be helpful and used as a reference.

Thank you 👍

janbolat avatar Oct 27 '21 07:10 janbolat

Thank you for reporting this! We will take a look. And thank you for useful examples as well.

izzytwosheds avatar Oct 27 '21 18:10 izzytwosheds

Sorry, is there an ETA on this?

janbolat avatar Nov 03 '21 17:11 janbolat

Looking into this. No ETA yet, though.

izzytwosheds avatar Nov 04 '21 18:11 izzytwosheds

Hi, I was able to make it work by replacing all the filters with the filters in GPUVideo-android :D I'm new to OpenGL, but I guess multiple filters didn't work mainly because it doesn't have GlFramebufferObject which is used in GlFilterGroup.

I will try to make it work with the current filters and create a PR next week, hopefully.

Thank you.

janbolat avatar Nov 06 '21 19:11 janbolat

Thank you for the analysis and for proactivity. I will look at possible solutions meanwhile. Looking forward to collaborating on your PR!

izzytwosheds avatar Nov 08 '21 17:11 izzytwosheds

Hi @janbolat could you share more on how you replace the filters with GPUVideo-android one? I couldn't make it works

fchristysen avatar Dec 08 '21 12:12 fchristysen

Is there any update on this ?

Fgabz avatar May 24 '22 10:05 Fgabz

It is on my todo list, pretty high up. Finding time to getting this actually done has been difficult.

izzytwosheds avatar May 25 '22 13:05 izzytwosheds