Same comment is left on an unchanged line

[echarrod]

Describe the bug

For a given review, a comment is left, but this comment is also left for an unaffected line (was not changed at all). This means "unable to load diff" is shown in main PR view (on GitLab), and in the changes view, the same comment is left twice

Expected behavior

• Comments are not left on lines that are unchanged

Screenshots

Main MR view:

Files changed view:

Additional context

• Updated to docker version v1.0.142 today

[yeelali14]

Hi @echarrod , could you share the MR URL? We’re checking it now

[echarrod]

Hi @echarrod , could you share the MR URL? We’re checking it now

It's on a private GitLab repo I'm afraid, we're running the docker image v1.0.142 against it

[yeelali14]

@echarrod yeah, I just need this to track the code review request in the logs

[yeelali14]

Also, I can’t reproduce this scenario—can you briefly describe what changed?

[echarrod]

Ah thanks. URL = https://gitlab.com/lunomoney/product-engineering/core/-/merge_requests/65992

We updated from 1.0.141 to 1.0.142, and got the inline comments, but some were invalid in that they were leaving the same comment twice - one on the actual line changed, and then one in a line above it, which hadn't changed. This comment manifested as "unable to load the diff" in the comment, as shown in the 1st screenshot

[yeelali14]

In rare cases we may comment on an unchanged line if the review flags an existing issue, but it definitely shouldn’t show “unable to load the diff” on the main PR page. Could be a race condition. I’ll try to reproduce and get a fix out fast. Thank you! 🙏

[echarrod]

Happened again on https://gitlab.com/lunomoney/product-engineering/core/-/merge_requests/66351 (and we updated to 1.0.143)

[EladKohavi]

Hey, We're looking into this :)