line-bot-sdk-php icon indicating copy to clipboard operation
line-bot-sdk-php copied to clipboard

Manage config to run openapi generator in one file

Open Yang-33 opened this issue 11 months ago • 1 comments

Currently, the configuration for openapi-generator for line-bot-sdk-php is written in three workflows, which is a source of errors. Additionally, in the repository managing the OpenAPI schema, it's easy to forget to synchronize the settings.

One solution is to provide just one configuration file or script in this repository and have the CIs simply use it.

  1. https://github.com/line/line-bot-sdk-php/blob/d012e5c459bbcb1358aae73fd9094a468c5f3625/.github/workflows/generate-code.yml#L31-L51

  2. https://github.com/line/line-bot-sdk-php/blob/d012e5c459bbcb1358aae73fd9094a468c5f3625/.github/workflows/php-checks.yml#L34-L54

  3. https://github.com/line/line-openapi/blob/0af4f53f23960ae0019526f631cf0fe81528e03f/.github/workflows/sdk-testing.yml#L133-L153

Yang-33 avatar Mar 11 '25 10:03 Yang-33

Other repositories use generate-code.py for this, so for consistency, it might be a good idea to do the same in this repository.

Yang-33 avatar Mar 13 '25 02:03 Yang-33