kod icon indicating copy to clipboard operation
kod copied to clipboard

Vertical scrolling not working

Open emigr2k1 opened this issue 7 years ago • 6 comments

Using MacOS Mojave, ITerm and default MacOS terminal.

If I write lines until they fill the viewport I cannot see the new lines. Kod still receives my input because if I delete the first lines I can see what I wrote.

Video

I can work on it. I just need a clue about why it doesn't work on mac because I see that it works on linux (I suppose, by looking at the screenshot in README.md)

emigr2k1 avatar Sep 26 '18 07:09 emigr2k1

Hey, great! I just noticed this myself as well and i'm guessing that xi has changed the protocol a bit since it was implemented in kod. That's the reason why it works in the screenshot.

Would be awesome if you wanted to take a peek at it @emigr2k1 ! :smile:

linde12 avatar Sep 26 '18 07:09 linde12

Checking the log, it looks like Kod is not handling the method "scroll_to" which was an op of "update" before. I'll send a PR tomorrow if I can :)

emigr2k1 avatar Sep 26 '18 10:09 emigr2k1

Awesome!

linde12 avatar Sep 26 '18 10:09 linde12

Have you guys ever gotten this to work again? I'm still experiencing it...

sixtyfive avatar Sep 27 '18 11:09 sixtyfive

@sixtyfive Not yet, but @emigr2k1 has figured out the root cause. It worked in the past but xi-editor is under development and API changes from time to time so kod doesn't handle it correctly with the latest version of xi-core.

linde12 avatar Sep 27 '18 13:09 linde12

How should the scroll be handled? Do you have any idea on how to do this? Should we simulate scrolling just replacing the lines in the viewport or render all the lines and actually scroll the viewport (I don't know if that'a possible)? I have an almost working version of scrolling just rendering the lines in the viewport but I'm having problems when there's an update of invalidBefore in linecache, I could do a hack to fix it but it would look dirty.

emigr2k1 avatar Oct 01 '18 06:10 emigr2k1