whois-parser icon indicating copy to clipboard operation
whois-parser copied to clipboard

Adds support for parsing the reseller name

Open csnitker-godaddy opened this issue 2 years ago • 5 comments

Added support for parsing the reseller name if it's present. I'm not sure the reseller attribute belongs on the domain struct but it seems to be a better fit than adding it to the Contact struct.

csnitker-godaddy avatar May 02 '23 15:05 csnitker-godaddy

Hello @csnitker-godaddy Thanks for your PR.

I think it is better to put it here as a Contact, do you think so?

// WhoisInfo storing domain whois info
type WhoisInfo struct {
        Domain         *Domain  `json:"domain,omitempty"`
        Registrar      *Contact `json:"registrar,omitempty"`
------> Reseller       *Contact `json:"reseller,omitempty"`
        Registrant     *Contact `json:"registrant,omitempty"`
        Administrative *Contact `json:"administrative,omitempty"`
        Technical      *Contact `json:"technical,omitempty"`
        Billing        *Contact `json:"billing,omitempty"`
}

likexian avatar May 04 '23 01:05 likexian

I could move it to that level if that's preferred. though it would look like this (it's only a single string value):

// WhoisInfo storing domain whois info
type WhoisInfo struct {
        Domain         *Domain  `json:"domain,omitempty"`
        Registrar      *Contact `json:"registrar,omitempty"`
------> Reseller       *string  `json:"reseller,omitempty"`
        Registrant     *Contact `json:"registrant,omitempty"`
        Administrative *Contact `json:"administrative,omitempty"`
        Technical      *Contact `json:"technical,omitempty"`
        Billing        *Contact `json:"billing,omitempty"`
}

csnitker-godaddy avatar May 04 '23 13:05 csnitker-godaddy

it's NOT only a single string value, reseller also have name, email, url, address etc.

for example:

git.cat
12:Reseller: Netsto Limited
74:Reseller Email: 
75:Reseller URL: http://www.netsto.com
git.nl
3:Reseller Name: Yourhosting
4:Reseller Address: Ceintuurbaan 28
5:Reseller Address: 8024AA Zwolle
6:Reseller Address: Netherlands

likexian avatar May 05 '23 00:05 likexian

Hello @csnitker-godaddy What is nyc means? It is not readable.

likexian avatar Mar 01 '24 01:03 likexian

Hello @csnitker-godaddy By the way, since you work in godaddy, would you please feedback a godaddy issue of https://github.com/likexian/whois/issues/17 ?

likexian avatar Mar 01 '24 01:03 likexian