PassAndroid icon indicating copy to clipboard operation
PassAndroid copied to clipboard
verified publisher icon ligi

Added menu button to show a notification of the current pass for quick access

Open daTom24 opened this issue 5 years ago • 2 comments

Added menu button to show a notification of the current pass for quick access video: https://imgur.com/Ie456rB

daTom24 avatar Mar 03 '20 21:03 daTom24

This looks cool! Thanks for the PR. I did not have a look at the code though. Does an issue exist where this feature is proposed/discussed? If yes, please link it in this PR.

I never saw something like this. Do you have any references for this kind of UX? I'd say it's quite unusual to trigger a notification manually. But I also don't know, if such a feature is needed overall and if yes whether the notification should be shown automatically.

Regarding automatic notifications: IIRC Apple Wallet shows a notification when you're close to a venue and have a valid pass. But this is just something that came to my mind right now. Not necessarily related to this PR.

simontb avatar Mar 04 '20 21:03 simontb

Thanks so much for the PR. But I agree with @simontb that I think this pattern is not very common. So I am a bit hesitant with merging. What I could imagine: A setting in each pass with "notification before" and then "always" could be one setting that basically is this feature you want. What do you think?

ligi avatar Mar 05 '20 00:03 ligi