lightstep-tracer-python icon indicating copy to clipboard operation
lightstep-tracer-python copied to clipboard
verified publisher icon lightstep

Fixed the examples argument parser problem of not handling booleans

Open andrewcheelightstep opened this issue 7 years ago • 3 comments

Modified the argument parser for the --use_tls argument because it wasn't parsing booleans correctly.

andrewcheelightstep avatar May 10 '18 22:05 andrewcheelightstep

Hey @andrewcheelightstep

Thanks for the PR (and sorry for the delayed review). The change looks right, and the only thing I wonder is the default value - before this change, the expected default value was to use TLS, while with this change the default would be to not use it.

Maybe we should rename it to no_tls, so by default we stil use TLS? Else, we can merge, I'd say.

@katiabazzi @frenchfrywpepper

carlosalberto avatar Jul 09 '18 17:07 carlosalberto

Agree with @carlos - it's just an example program, but --disable_tls seems like a better name for this behavior. Then we can set store_false and default to TLS

joeblubaugh avatar Jul 11 '18 17:07 joeblubaugh

I have no problems with this. Is this something we can merge soon?

andrewcheelightstep avatar Jul 30 '18 19:07 andrewcheelightstep