framework icon indicating copy to clipboard operation
framework copied to clipboard

Please publish for Scala 2.13.0-RC1

Open Sciss opened this issue 7 years ago • 16 comments

https://github.com/dispatch/reboot/issues/210 depends on net.liftweb#lift-json to be available for Scala 2.13.0-M5.

Sciss avatar Dec 26 '18 11:12 Sciss

We don't generally publish builds for Scala milestones, though we sometimes run the builds. Is there a compelling reason we would do this? I don't know that dispatch makes a habit of doing published milestone builds, either.

Shadowfiend avatar Jan 04 '19 21:01 Shadowfiend

Well, the compelling reason is that consumers of the library can prepare their transition to Scala 2.13.0. If not for M5, a good point will be RC1. Since Scala 2.13.0 comes with API change (new collections), the transition process is a bit more work than just relying on source compatibility. Identifying problems with the new collections API early will be generally helpful. Thanks!

Sciss avatar Jan 04 '19 22:01 Sciss

I think we'd be amenable to a PR here; most of the team is currently busy with Real Life™ but I think we can find the bandwidth for a quick code review + merge + snapshot publish.

Shadowfiend avatar Jan 26 '19 02:01 Shadowfiend

code review + merge + snapshot publish.

Just want to re-iterate that we'd be open to this. We actually publish snapshots on each master merge so all we'd need to do is get this building in master.

farmdawgnation avatar Feb 01 '19 04:02 farmdawgnation

I see there's some activity over at https://github.com/lift/framework/pull/1962

SethTisue avatar Aug 07 '19 03:08 SethTisue

This is a great point, and in fact most of the blockers over there are unrelated to lift-json... While we historically haven’t done any per-module releases, given how much time we respectively have, I may look at how complicated it might be to do a manual milestone release or something for lift-json on Scala 2.13. I’ll bring it up on the list; thanks for the reminder/bump!

Shadowfiend avatar Aug 07 '19 10:08 Shadowfiend

I wouldn’t be opposed to running the per module releases

farmdawgnation avatar Aug 10 '19 14:08 farmdawgnation

Is there a version for Scala 2.13 in sight? That would be pretty nice.

Marcel-B avatar Oct 13 '19 20:10 Marcel-B

The current SNAPSHOT build is built for 2.13 for most (barring certain persistence ones) Lift modules (as of a few days ago).

Shadowfiend avatar Oct 13 '19 22:10 Shadowfiend

Thank you very much for the quick answer. SBT could load yesterday only under Scala 1.12.x lift-json. Then I saw on https://mvnrepository.com/artifact/net.liftweb/lift-json that only json-lift up to 1.12.x is supported and I thought that this is the problem. But this morning it worked under version 1.13.x. Unfortunately I didn't find out why.

image

Marcel-B avatar Oct 14 '19 06:10 Marcel-B

You'll want to add the snapshot resolver (see this example) and use 3.4.0-SNAPSHOT as your version. The 3.4 snapshot contains a handful of targeted bug fixes and 2.13 support, so you should be safe to use it. I need to circle up with the other committers to see how we want to handle doing the actual 3.4 release, and if we want to ship it before all modules are building on 2.13.

Shadowfiend avatar Oct 15 '19 12:10 Shadowfiend

Folks, the 3.4.0 final release with support for Scala 2.13 on most modules is now out.

We'll keep this issue open a bit longer as we work towards rounding out the remaining modules and including them in subsequent 3.4.x releases.

Shadowfiend avatar Oct 23 '19 12:10 Shadowfiend

Anyone using lift-jpa? We are:-) @dchenbecker Are you still around? Want to release a 2.13-version?

andreak avatar Oct 23 '19 13:10 andreak

We don't have a 3.0 version of lift-jpa, right? I believe @dpp dropped it in an early 3.0 commit (though I can't find any mention of it being dropped beyond that commit).

Shadowfiend avatar Oct 23 '19 13:10 Shadowfiend

The artifact is:

			<dependency>
				<groupId>org.scala-libs</groupId>
				<artifactId>scalajpa_2.12</artifactId>
				<version>1.5</version>
			</dependency>

So it's actually never been a part of Lift...

andreak avatar Oct 23 '19 13:10 andreak

Ah! Lift had a module adding some support for scala-jpa in the 2.x series, which is why I got confused.

Looks like https://github.com/dchenbecker/scalajpa is the repo for that project.

Shadowfiend avatar Oct 23 '19 13:10 Shadowfiend