types icon indicating copy to clipboard operation
types copied to clipboard
verified publisher icon lifinance

chore: update Action fromAddress property to required

Open rialco opened this issue 2 years ago • 5 comments

rialco avatar Oct 24 '23 02:10 rialco

@mathiasmoeller This won't break anything on the frontend, so if you need this go for it here so we can have the same types

chybisov avatar Mar 12 '24 09:03 chybisov

But it could break any other partner integration. @rialco can we close this PR?

mathiasmoeller avatar Mar 12 '24 09:03 mathiasmoeller

But it could break any other partner integration. @rialco can we close this PR?

Which one? SDK v3 is still in alpha, and v2 uses types v9

chybisov avatar Mar 12 '24 09:03 chybisov

People using the API directly. If they don't pass the fromAddress in the Action yet it will break

mathiasmoeller avatar Mar 12 '24 10:03 mathiasmoeller

is it safe to discard it?

myz1237 avatar Jun 04 '24 10:06 myz1237