binarytree
binarytree copied to clipboard
[#395] Fix some sonar cloud issues
Pull Request Overview
Fix some sonar issues
Changes Introduced
Fix some sonar issues
Linked Issue(s)
- Fixes #395
Testing Strategy
- [ ] Describe how you have tested these changes
- [ ] Include details of any new unit/integration tests added
- [ ] Mention any edge cases considered or testing environments (e.g., browser versions, mobile)
Performance and Accessibility Considerations
- [ ] Confirm no significant performance drops. Use tools like Lighthouse for performance evaluation.
- [ ] Ensure new UI components are accessible (e.g., screen reader-friendly, keyboard navigable)
Code Quality Checks
- [ ] Confirm self-review of code, including readability and maintainability
- [ ] Verify adherence to project coding standards
- [ ] Ensure proper documentation of functions and classes, if applicable
Console Warning/Error Checks
- [ ] Confirm no new warnings or errors are showing in the console
Configuration Changes
- [ ] If applicable, describe any changes to project configurations (e.g.,
vite.config.ts,tsconfig.json)
Screenshots/Video
- [ ] Include screenshots/video demonstrating UI changes (if applicable)
Additional Notes
- [ ] Add any other context or notes about the pull request here (optional)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| binarytree-rssfeed-api | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 21, 2024 0:05am |
Deploy Preview for binarytree-dev ready!
| Name | Link |
|---|---|
| Latest commit | cc6a34a1dd0c1ee95ce0b34dd306a8039a0443f4 |
| Latest deploy log | https://app.netlify.com/sites/binarytree-dev/deploys/664c8e02c8f72c0008733965 |
| Deploy Preview | https://deploy-preview-452--binarytree-dev.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@panagiotisbellias Thank you for your contribution. Could you please check the build at https://app.netlify.com/sites/binarytree-dev/deploys/661fc3144c127300088d48c0 It seems to be failing.
Let me know if you have any questions.
I'll check it as soon as possible