Walter Hop
Walter Hop
I certainly wouldn't mind this! One thing, did you mean `.bz2` instead of `.b2` ?
HMMMM! I was confused. I thought we were already blocking .zip, and adding other archive types would add consistency - but it seems I added .zip to my custom config...
Yeah, good point. Maybe we should just add them as an additional example in crs-setup.conf.example, so users can choose to block these files, but not include them in the defaults?...
I like that too. Also because I can disable that extra rule on a virtualhost when I do need to host archives.
Tests are failing now, but that could be due to a temporary problem with our pipeline that should be solved now. Re-running jobs.
Two test failures persist: running 932100-28: 💥 failed in 4.404215ms - POST data: `arg=;gcc10.1` running 932100-29: 💥 failed in 4.240415ms - POST data: `arg=;irb31`
Sorry I don't have a phpMyAdmin 5 in production. I could set one up, but I have almost no time so that could take a while.
We have a rule for backslash notation in the [contribution guidelines](https://coreruleset.org/docs/development/contribution_guidelines/): `\\`should be written as `\x5c` Please if possible could you put it after the `/` also for improved clarity....
Oops. Seems that the test is failing: ``` test_crs[932200.yaml -- 932200-14] assert False ``` Is the test wrong or does the rule have a problem? Could you have a look...
This issue may be harder than it looks (or maybe not). I am confused because as far as I know, we should have detected this technique also in earlier releases....