dolphin icon indicating copy to clipboard operation
dolphin copied to clipboard

Update of core

Open Papermanzero opened this issue 5 years ago • 11 comments

The main branch received several updates. Especially the new lossless format RVZ is a great achievement.

Papermanzero avatar Jul 19 '20 09:07 Papermanzero

+1 for an upstream update

ordovice avatar Jul 28 '20 16:07 ordovice

You may have had your wish:

https://github.com/libretro/dolphin/commit/56e9a017d0dffe923391ea750f9aa914486a1c45

i30817 avatar Aug 29 '20 08:08 i30817

Thanks a lot!!!

Papermanzero avatar Aug 29 '20 08:08 Papermanzero

It does look like it was updated, but not built yet on the buildbot. I'm hoping the new RVZ compressed image format is supported by the core.

Big thanks to the Libretro team for updating the Dolphin core!

Mr-Jake avatar Aug 29 '20 15:08 Mr-Jake

I don't think it does support RVZ. Or at least a search for 'RVZ' on the repository doesn't show any commits or code for the string. Which is kind of weird if you ask me, if dolphin master was merged.

ie compare these searches:

dolphin: https://github.com/dolphin-emu/dolphin/search?q=RVZ_MAGIC&unscoped_q=RVZ_MAGIC

libretro dolphin: https://github.com/libretro/dolphin/search?q=RVZ_MAGIC&unscoped_q=RVZ_MAGIC

Maybe github hasn't indexed the code yet, lets see if the files exist.

edit: yes, it was that, the RVZ strings are in those files in libretro. Whew.

i30817 avatar Aug 29 '20 19:08 i30817

It supports RVZ with the newest updates.

Papermanzero avatar Nov 08 '20 15:11 Papermanzero

Source/Core/DolphinLibretro/Main.cpp still needs void retro_get_system_info(retro_system_info* info) to be updated for the WIA and RVZ file extensions. I tried downloading and compliling myself, but something went wrong, and I don't wanna try submitting a pull request unless I can do a successful build.

EDIT: Oh also I don't have permissions to do Pull Requests. Which I found out after getting a successful build. Or at least I don't think I do. Development is confusing sometimes. EDIT 2: Ok, forked, committed to my repo, Pull Request made. Yay I'm helping. I think. #179

Formedras avatar Nov 24 '20 10:11 Formedras

https://github.com/hunterk/libretro_builds

those builds run rvz without issue

Papermanzero avatar Nov 24 '20 20:11 Papermanzero

Well yes they run RVZ images without issue, but my point wasn't about running them, it was about detecting them in the RetroArch GUI. Although the core could handle the files just fine if given an RVZ or WIA file, it wasn't telling RetroArch (or other Libretro frontends) that they're acceptable, so they wouldn't show up in the file browser.

Formedras avatar Nov 25 '20 11:11 Formedras

I see. Well, I am generating my playlists manually due to certain rom hacks and translations. But awesome that you implemented that feature 👍

Papermanzero avatar Nov 25 '20 17:11 Papermanzero

Adding RVZ detection to the GUI frontend, officially, would be helpful :p

ThisNekoGuy avatar Oct 27 '21 21:10 ThisNekoGuy