python-librato icon indicating copy to clipboard operation
python-librato copied to clipboard

Support for web proxy

Open frennkie opened this issue 10 years ago • 3 comments

I noticed that python-librato does not provide any support for being operated through a web proxy (https_proxy). I was planning to operate a librato client within a corporate network but the only way to access internet resources from there is to use an authenticating web proxy. If I'm wrong please give me some pointers on how to configure proxy settings - otherwise: are there any plans to enable handling of proxy requests?

Thanks, kind regards frennkie

frennkie avatar Oct 30 '15 23:10 frennkie

Hi @frennkie,

I spawned a branch to explore this. Can you give it a try in your environment? Notice you'll have to change the proxy host, port and auth credentials based on your proxy setup.

drio avatar Nov 02 '15 16:11 drio

Hi @drio,

I'm not in the office anymore and I'm not sure how much time I'll have for this at work. So I just set up a squid3 proxy, configured authentication, tested your modification and it works!

Let me know if you need anything else.

Thanks frennkie

frennkie avatar Nov 02 '15 19:11 frennkie

:boom: Excellent. Thanks for checking. I will refine the PR to make it more user friendly. Stay tuned !

drio avatar Nov 02 '15 19:11 drio