queso icon indicating copy to clipboard operation
queso copied to clipboard

How to deal with `RngBoost`

Open dmcdougall opened this issue 9 years ago • 6 comments

We have an RNG interface and at present we can select between gsl and boost, although I'm not sure if the boost interface is functional.

Since we're moving towards making boost an optional dependency (requiring it only when the compiler is old enough), I thought I'd open this ticket to discuss what we can do about the random number generation.

When the compiler is new enough, of course we can use the random number generators in the C++11 standard library. If it isn't new enough, should we fall back to boost or use something else?

dmcdougall avatar Jul 28 '16 03:07 dmcdougall

IMHO, I'd say get rid of the Boost one, particularly since the C++11 one has been added. Then, if the user doesn't have a new enough compiler (anyone on RHEL/CentOS 7 does), they can fall back to GSL. Just my two cents.

pbauman avatar Jan 13 '17 22:01 pbauman

Fall back on GSL, but when GSL's not there fall back on Boost. We're trying to get to "User needs C++11 or Boost but doesn't need both" in the long run, with GSL purely optional for licensing reasons.

roystgnr avatar Jan 13 '17 22:01 roystgnr

Fair enough. Was just hoping we could strip away Boost entirely and not have maintain it since it's been such a PITA.

pbauman avatar Jan 13 '17 22:01 pbauman

You will be able to if you're compiler is new enough.

Edit: your

dmcdougall avatar Jan 14 '17 01:01 dmcdougall

You will be able to if you're compiler is new enough.

Right, I understand. I was just hoping to be able to reduce the QUESO maintenance burden by stripping out Boost entirely. But the licensing point is fair, particularly since QUESO is not all-in C++11 yet.

pbauman avatar Jan 14 '17 02:01 pbauman

Right, I understand. I was just hoping to be able to reduce the QUESO maintenance burden by stripping out Boost entirely. But the licensing point is fair, particularly since QUESO is not all-in C++11 yet.

The licensing point should actually be called a licensing 'uncertainty'. It's not that GSL's license is prohibitive, it's that none of us know it's prohibitive because none of us are lawyers.

dmcdougall avatar Jan 14 '17 02:01 dmcdougall