libp2p
feat: direct messages
- Adds direct messaging between connected peers with protobufs
Hopefully a bit simpler than the previous PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| universal-connectivity | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 5, 2024 8:59pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
I made a couple of small suggestions in as I'm going through the PR and testing https://github.com/dozyio/universal-connectivity/pull/6/ (which I couldn't push directly here)
Great stuff! I left a bunch of comments and small suggestions in a separate PR.
From a UX perspective, my suggestion would be to remove the peer menu to reduce the number of clicks. For peer not supporting DMs, this could be a hover tooltip.
Thanks @dozyio
Thanks for the PR - merged... was going to add a bit more functionality with the menu, but can do that on a separate pr. Will remove for now
@dozyio Is this ready for another review?
@2color Sorry didn't see this reply! - yes good for another review
Just need to resolve the conflicts.
resolved
I would highlight the peer you are DMing in the peer list. But we can do that in a separate PR.
Good idea - will sort something out next week
@2color can we merge this?
would like to do the js-libp2p 2.0 upgrade next week if possible