test-plans icon indicating copy to clipboard operation
test-plans copied to clipboard

feat(perf): Allow for test filtering + Github composite action

Open maschad opened this issue 2 years ago • 13 comments

This PR adds a Github composite action that allows a repository to trigger the perf runner workflow for specific implementations e.g. js-libp2p only. This would facilitate running benchmarks on a release workflow for instance.

Related https://github.com/libp2p/js-libp2p/issues/1964

Closes https://github.com/libp2p/test-plans/issues/259

maschad avatar Aug 25 '23 19:08 maschad

@mxinden would you be able to trigger a test run for this?

maschad avatar Aug 29 '23 23:08 maschad

Sorry for the delay here. https://github.com/libp2p/test-plans/pull/284 might have messed with our current setup. I am working on it.

mxinden avatar Aug 31 '23 18:08 mxinden

master works again. Let me know once you want a review here.

mxinden avatar Sep 04 '23 13:09 mxinden

Thanks @mxinden I think we should trigger a run first and then once that's successful, I can change it from a draft PR to be an open one.

maschad avatar Sep 04 '23 16:09 maschad

@p-shahi would you be able to trigger a run for this on CI?

maschad avatar Sep 07 '23 19:09 maschad

Triggered perf run https://github.com/libp2p/test-plans/actions/runs/6149594863

p-shahi avatar Sep 11 '23 17:09 p-shahi

Thanks for triggering that run @p-shahi I've made some adjustments to the workflow again. Would you be able to do a re-trigger?

maschad avatar Sep 11 '23 19:09 maschad

test run: https://github.com/libp2p/test-plans/actions/runs/6202929488

p-shahi avatar Sep 15 '23 21:09 p-shahi

@mxinden would you be able to review this?

maschad avatar Oct 06 '23 01:10 maschad

@maschad to fix the conflict and tag @dhuseby for review

dhuseby avatar May 07 '24 15:05 dhuseby

@dhuseby I've resolved the conflicts. Thanks for reviewing this.

maschad avatar May 07 '24 21:05 maschad

refs https://github.com/libp2p/js-libp2p/issues/2545

dhuseby avatar May 14 '24 15:05 dhuseby

@maschad when I ran this, I got this error: https://github.com/libp2p/test-plans/actions/runs/9765760822/job/26957195395#step:3:378

dhuseby avatar Jul 02 '24 18:07 dhuseby