go-libp2p-examples icon indicating copy to clipboard operation
go-libp2p-examples copied to clipboard
verified publisher icon libp2p

How can I help PRs get merged?

Open NickEckardt opened this issue 5 years ago • 2 comments

I would like to help fix some of the examples with this repo, however it's been a long time since the last PR got merged. I'm worried if I submit a PR it won't get looked at. Is there something blocking review of those PRs that I could help with?

NickEckardt avatar Jan 04 '21 00:01 NickEckardt

IMO the best thing that would help this repo is testing. Otherwise the reviewer has to take a much more manual approach to approval.

aschmahmann avatar Jan 04 '21 04:01 aschmahmann

I added a few tests in #193, let me know if I'm on the right track or if a different approach would be better.

NickEckardt avatar Jan 05 '21 03:01 NickEckardt