PB-4578: Fix RT CR status with duplicate resources and RT controller with duplicate effort.
- Remove loop on the paths in the validateTransformResource as this is already been doing in the resourcecollector.TransformResources
- Because of this redandent computation issue is solved and RT CR status will not be overloded with duplicate resource information.
- Remove path.Operation validation in validateTransformResource as this is already completed with the RT CR is in Initial Stage using the ResourceTransformationController.validateSpecPath method.
What type of PR is this?
Uncomment only one and also add the corresponding label in the PR: bug feature improvement cleanup api-change design documentation failing-test unit-test integration-test
What this PR does / why we need it: To fix the performance while transforming resources in rt controller by removing the redundant computations which are even occupying the RT CR status
Does this PR change a user-facing CRD or CLI?: no
Is a release note needed?: no
Issue:
User Impact:
Resolution
Does this change need to be cherry-picked to a release branch?: Yes because it is a bug in the latest release stork release.
JIRA BUG: https://portworx.atlassian.net/browse/PB-4578
Unit Test Result
Can one of the admins verify this patch?
Codecov Report
All modified lines are covered by tests :white_check_mark:
Comparison is base (
56aa1f2) 65.93% compared to head (686c1ea) 65.99%.
Additional details and impacted files
@@ Coverage Diff @@
## master #1529 +/- ##
==========================================
+ Coverage 65.93% 65.99% +0.05%
==========================================
Files 43 43
Lines 5349 5349
==========================================
+ Hits 3527 3530 +3
+ Misses 1490 1488 -2
+ Partials 332 331 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please add integration test to stork.
As discussed with anjan currently we can rely on unit tests Integration tests for the bug will be added as a separate task by the stork team.