libigl-python-bindings icon indicating copy to clipboard operation
libigl-python-bindings copied to clipboard
verified publisher icon libigl

Tutorial 3: missing data

Open kampelmuehler opened this issue 4 years ago • 2 comments

All the example data for Tutorial 3 is not in the repository

https://github.com/libigl/libigl-python-bindings/blob/40be4c4fa5b8b77d37128b944883656d809d2444/tutorial/tut-chapter3.ipynb

kampelmuehler avatar Aug 23 '21 07:08 kampelmuehler

I checked some random and they are here: https://github.com/libigl/libigl-tutorial-data

Which one is missing?

teseoch avatar Sep 29 '21 16:09 teseoch

I was expecting the data to be here https://github.com/libigl/libigl-python-bindings/tree/master/tutorial/data which is basically empty. Maybe it would be enough to leave a README.md there on where to find the data?

kampelmuehler avatar Oct 28 '21 07:10 kampelmuehler

The cmake will download the tutorial data, but this is an admittedly weird way to get it. Right now the data is downloaded optionally during build. If someone installed with pip, e.g., and just wants to try out the tutorial then it's awkward to get the data. A couple ideas:

  • improve the cmake download scripts so that they can be called without building the bindings,
  • download the tutorial data via python (e.g., download_data_for_tutorial.py), or
  • move the tutorial to a different repo

alecjacobson avatar Feb 05 '23 23:02 alecjacobson

Thanks for taking care of this!

kampelmuehler avatar Feb 07 '23 08:02 kampelmuehler