typecheck-part-1

Open DinhHuy2010 opened this issue 11 months ago • 2 comments

Split from https://github.com/libgit2/pygit2/pull/1332

Feb 17 '25 12:02 DinhHuy2010

Thanks @DinhHuy2010 for the contribution. And thanks @Tsafaras for the review, I agree with the comments.

Regarding select/ignore, it should be more specific. I've pushed a commit where just the F401, F403 and F405 rules are ignored, and only in the concerned files pygit2/__init__.py and pygit2/ffi.py

Now ruff check pass, so I think this PR is not relevant at this time (maybe some changes here are related to PR #1332)

@DinhHuy2010 Could you open other PRs with work from PR #1332 ?

Feb 25 '25 14:02 jdavid

hi, sorry for waiting yes I probably will make a new PR'

and yes @Tsafaras, I forgot to change to new style (and also did not know about the --add-noqa argument)

Alright, Let me fix the changes.

Thanks.

Feb 26 '25 14:02 DinhHuy2010