libbpf-sys icon indicating copy to clipboard operation
libbpf-sys copied to clipboard

Support for building Android platforms

Open editso opened this issue 1 year ago • 6 comments

  1. Add header files required for the Android platform
  2. Manually implement libbpf_set_print instead of using bindgen to automatically generate it, to solve the va_list error
  3. Modify build.rs to use the cc library instead of the make command for building, and support building for Android
  4. Added Android testing in CI

editso avatar Jun 28 '24 11:06 editso

Sorry, but the third commit is unreviewable. There is no explanation why anything is being done. Is it so plainly obvious why we are suddenly changing out half the implementation? It certainly isn't to me. And again, this commit does a thousand things, all in one go, without any obvious moves or anything. Perhaps someone has the time to match up each removed line with each addition, I don't. Please split it to allow people to understand individual changes, not just replace one huge blob with another.

danielocfb avatar Aug 19 '24 20:08 danielocfb

The rest looks reasonable.

danielocfb avatar Aug 19 '24 20:08 danielocfb

Sorry, but the third commit is unreviewable. There is no explanation why anything is being done. Is it so plainly obvious why we are suddenly changing out half the implementation? It certainly isn't to me. And again, this commit does a thousand things, all in one go, without any obvious moves or anything. Perhaps someone has the time to match up each removed line with each addition, I don't. Please split it to allow people to understand individual changes, not just replace one huge blob with another.

This is my first time submitting code to the community. Thank you for your guidance. I have split it into multiple commits. Please review it again

editso avatar Aug 20 '24 04:08 editso

No worries. Didn't get a chance to take another look today, but should be able to review tomorrow.

danielocfb avatar Aug 20 '24 23:08 danielocfb

@editso, thank you for working on adding Android support. I found this issue because a user asked for Android support in bpftop https://github.com/Netflix/bpftop/issues/91

Do you intend to continue working on the PR?

jfernandez avatar Sep 21 '24 12:09 jfernandez

@editso, thank you for working on adding Android support. I found this issue because a user asked for Android support in bpftop Netflix/bpftop#91

Do you intend to continue working on the PR?

Yes, I have had other things to do recently, so it has been delayed

editso avatar Sep 23 '24 16:09 editso

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 5 days.

github-actions[bot] avatar Dec 13 '24 02:12 github-actions[bot]

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 5 days.

github-actions[bot] avatar Jan 17 '25 02:01 github-actions[bot]

Plenty of questions still remain unanswered, so no point in giving it another pass to ask for clarification on the same topics.

danielocfb avatar Jan 17 '25 17:01 danielocfb

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 5 days.

github-actions[bot] avatar Feb 17 '25 02:02 github-actions[bot]

Closing pull request as it is stale.

github-actions[bot] avatar Feb 23 '25 02:02 github-actions[bot]