Support for building Android platforms
- Add header files required for the
Androidplatform - Manually implement
libbpf_set_printinstead of usingbindgento automatically generate it, to solve theva_listerror - Modify
build.rsto use thecclibrary instead of themakecommand for building, and support building forAndroid - Added
Androidtesting inCI
Sorry, but the third commit is unreviewable. There is no explanation why anything is being done. Is it so plainly obvious why we are suddenly changing out half the implementation? It certainly isn't to me. And again, this commit does a thousand things, all in one go, without any obvious moves or anything. Perhaps someone has the time to match up each removed line with each addition, I don't. Please split it to allow people to understand individual changes, not just replace one huge blob with another.
The rest looks reasonable.
Sorry, but the third commit is unreviewable. There is no explanation why anything is being done. Is it so plainly obvious why we are suddenly changing out half the implementation? It certainly isn't to me. And again, this commit does a thousand things, all in one go, without any obvious moves or anything. Perhaps someone has the time to match up each removed line with each addition, I don't. Please split it to allow people to understand individual changes, not just replace one huge blob with another.
This is my first time submitting code to the community. Thank you for your guidance. I have split it into multiple commits. Please review it again
No worries. Didn't get a chance to take another look today, but should be able to review tomorrow.
@editso, thank you for working on adding Android support. I found this issue because a user asked for Android support in bpftop https://github.com/Netflix/bpftop/issues/91
Do you intend to continue working on the PR?
@editso, thank you for working on adding Android support. I found this issue because a user asked for Android support in
bpftopNetflix/bpftop#91Do you intend to continue working on the PR?
Yes, I have had other things to do recently, so it has been delayed
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 5 days.
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 5 days.
Plenty of questions still remain unanswered, so no point in giving it another pass to ask for clarification on the same topics.
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 5 days.
Closing pull request as it is stale.