libmesh icon indicating copy to clipboard operation
libmesh copied to clipboard

Add map based point neighbor ghosting functor

Open friedmud opened this issue 7 years ago • 6 comments

Adds a superfast point neighbor ghosting functor that uses the nodes_to_elem_map. Apparently it does have some limitations with respect to some element types and refinement (see: https://github.com/libMesh/libmesh/pull/1859#issuecomment-427091562 ) - but I think it should still be useful in 99% of cases.

friedmud avatar Oct 09 '18 23:10 friedmud

Damn - I messed up something with metaphysicl. Any ideas @roystgnr and @lindsayad ?

friedmud avatar Oct 09 '18 23:10 friedmud

It looks as if somehow you had metaphysicl headers in include/*/ somewhere before running include/libmesh/rebuild_makefile.sh - could that possibly be the case? I just tried running that myself but it was a no-op (as it should be when I haven't added any headers). The script is hand-crafted but find .. -name '*.h' etc. doesn't leave much ambiguity.

roystgnr avatar Oct 10 '18 02:10 roystgnr

Custom in-tree build script is getting in the way! On Tue, Oct 9, 2018 at 8:40 PM roystgnr [email protected] wrote:

It looks as if somehow you had metaphysicl headers in include// somewhere before running include/libmesh/rebuild_makefile.sh - could that possibly be the case? I just tried running that myself but it was a no-op (as it should be when I haven't added any headers). The script is hand-crafted but find .. -name '.h' etc. doesn't leave much ambiguity.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/libMesh/libmesh/pull/1887#issuecomment-428418458, or mute the thread https://github.com/notifications/unsubscribe-auth/AC5XIPuATdigTLAJBhYTwtrlCu9SDO2yks5ujV4NgaJpZM4XUVBH .

permcody avatar Oct 10 '18 03:10 permcody

Yep - I had to basically copy all of the metaphysicl headers into include/metaphysicl to make my in-tree build work. I guess I then ran the scripts and accidentally added junk I didn't mean to add. Let me strip out all of that crap and re-push.

friedmud avatar Oct 10 '18 16:10 friedmud

Don't merge this yet. I want to do some more testing of it first....

friedmud avatar Oct 11 '18 00:10 friedmud

This PR has been marked "do not merge" since we are no longer accepting PRs into the master branch. All new PRs should be made on the devel branch instead. Once this PR's target branch has been updated to devel, the "do not merge" label will be removed.

jwpeterson avatar Mar 02 '22 20:03 jwpeterson