lexik
fix ltrim with left parts match
Hi @rtreffler-goldcore,
I open this PR in favor of the #314
We use a substr instead, I think we are good to merge
Thx for your feedback! it's really a silent bug that I had never encountered in 5 years: p
Hi @rtreffler-goldcore,
I open this PR in favor of the #314
We use a substr instead, I think we are good to merge
Thx for your feedback! it's really a silent bug that I had never encountered in 5 years: p
thanks, I appreciate your quick action, I believe that one is worth being ported for v5.* so people don't live on forks
I can 't maintain old release, because the code in the master branch has a big BC break with doctrine/dbal...
Maybe I could fix the v6., but v5. is too old
I can 't maintain old release, because the code in the master branch has a big BC break with doctrine/dbal...
Maybe I could fix the v6., but v5. is too old
imho this change can be cherrypicked safely, this file exists and is almost the same (just different import for Doctrine's Type(s) - https://github.com/lexik/LexikFormFilterBundle/blob/v5.0.10/Event/Subscriber/DoctrineORMSubscriber.php)
I'm soon gonna have anther fix (I hope) for you in that file, so I would love to have it in v5.0.11 presumably.
We don't have branches for each version, so I can't create a new tag from the master branch.
There is two solutions:
- migrate to the last version of the bundle (and update doctrime/orm and dbal in your project)
- or use an different alias in your dql
We don't have branches for each version, so I can't create a new tag from the master branch.
There is two solutions:
- migrate to the last version of the bundle (and update doctrime/orm and dbal in your project)
- or use an different alias in your dql
Sorry if I'm too pushy, maybe my understanding is wrong here.
But can't you branch a release/5.0.11 from v5.0.10 tag, cherrypick the change and create a v5.0.11 tag from that point ?
Thanks for you patience with me and explanation.