LexikFormFilterBundle icon indicating copy to clipboard operation
LexikFormFilterBundle copied to clipboard

Revert "Revert "Replaced use of ltrim as it doesn't work as intended.""

Open ph538834 opened this issue 6 years ago • 5 comments

Reverts lexik/LexikFormFilterBundle#301 Now that the reason for the revert is gone(fixed date in tests) can we reapply this?

ph538834 avatar May 07 '19 15:05 ph538834

original pr from @ianwilk52 https://github.com/lexik/LexikFormFilterBundle/pull/292

ph538834 avatar May 07 '19 15:05 ph538834

Given that the test issue has now been resolved, can this be merged?

codeTom avatar Dec 09 '20 04:12 codeTom

this is still an issue, can we merge it ? @spike31 is there additional work needed to merge it ?

rtreffler-goldcore avatar Oct 20 '21 12:10 rtreffler-goldcore

Hi @rtreffler-goldcore,

I'm not sure to know where is your problem, could you add some tests?

gilles-g avatar Oct 21 '21 07:10 gilles-g

Hi @rtreffler-goldcore,

I'm not sure to know where is your problem, could you add some tests?

This is something that was once merged by you (https://github.com/lexik/LexikFormFilterBundle/issues/292#issuecomment-455975107), the bug I've discovered while debugging other situation.

The way $fieldName is derived is not correct, then later it fails to inspect $metadata->associationMappings[$fieldName]. In my case alias for a table was pd and association was called product as a result $fieldName results to roduct. image

Ill try to add tests later during the day if the above explanation is not sufficient.

rtreffler-goldcore avatar Oct 21 '21 08:10 rtreffler-goldcore