hackett icon indicating copy to clipboard operation
hackett copied to clipboard

Round out data/list

Open Shamrock-Frost opened this issue 8 years ago • 4 comments

The git history should be a lot nicer now.

Shamrock-Frost avatar Nov 27 '17 18:11 Shamrock-Frost

This looks great. Two questions:

  1. Is there any reason to call /= not=? I think /= is an alright name, though I’m open to arguments against it.

  2. Can you add documentation for the functions added in the last of these three commits?

Thanks.

lexi-lambda avatar Nov 29 '17 00:11 lexi-lambda

For 1, I was copying what clojure called it (same with nth). I'll change it to /= to keep with haskell. I'll add documentation tonight, sorry for the delay.

Shamrock-Frost avatar Nov 29 '17 00:11 Shamrock-Frost

Oh, gotcha, I didn’t realize Clojure had a function named not=. It probably doesn’t matter too much, but I think it makes sense to stick with Haskell here.

And no worries—I’d just like to make it a policy to avoid adding functions to the standard library without also adding documentation, but there’s no rush.

lexi-lambda avatar Nov 29 '17 00:11 lexi-lambda

The documentation has been added.

Shamrock-Frost avatar Nov 29 '17 22:11 Shamrock-Frost