setup icon indicating copy to clipboard operation
setup copied to clipboard

Update yarn installation instructions

Open ajdubovoy opened this issue 1 year ago • 9 comments

resolve https://github.com/lewagon/setup/issues/464

ajdubovoy avatar May 22 '24 08:05 ajdubovoy

@Eschults implemented the recommendation in https://github.com/lewagon/setup/issues/464.

But, I don't really have a good way of testing it. I did find corepack is installed on my system already, so this bodes well.

@ElvisDot do you maybe have a burner system you could test this on hahah? No worries if no!

I could also always try setting up a DigitalOcean droplet for a day and see if I can run our setup via SSH on Ubuntu, I guess.......

ajdubovoy avatar May 22 '24 08:05 ajdubovoy

No worries! But do we feel comfortable merging this without having at least tested it on Windows once?

ajdubovoy avatar May 22 '24 15:05 ajdubovoy

Let's ask in #teachers if someone is on Windows and would be so kind to run the two commands for us 😇

Eschults avatar May 22 '24 15:05 Eschults

Ok will do!

ajdubovoy avatar May 22 '24 15:05 ajdubovoy

https://lewagon-alumni.slack.com/archives/G02NFDT0J/p1716393474945849

ajdubovoy avatar May 22 '24 16:05 ajdubovoy

Hmmm so apparently it doesn't work with our node version on Ubuntu.

https://lewagon-alumni.slack.com/archives/G02NFDT0J/p1716555678386209?thread_ts=1716393474.945849&channel=G02NFDT0J&message_ts=1716555678.386209

I guess should we table merging this until we upgrade mode?

ajdubovoy avatar May 24 '24 15:05 ajdubovoy

Works on my machine. Did not test a lot just corepack enable and using yarn to install some package.

ElvisDot avatar May 27 '24 01:05 ElvisDot

It also seems like the issue on Natalia's computer was actually some kind of network error we haven't been able to solve yet. I do wonder if the same thing might happen to students, but it's also not necessarily a reason not to merge this

ajdubovoy avatar May 27 '24 06:05 ajdubovoy

I also think we don't use yarn at any point in the bootcamp anymore, so it wouldn't be a breaking problem if it didn't install on somebody's laptop

ajdubovoy avatar May 27 '24 06:05 ajdubovoy

👍

Eschults avatar Sep 26 '24 17:09 Eschults