data-setup icon indicating copy to clipboard operation
data-setup copied to clipboard

email privacy

Open Laiagdla opened this issue 1 year ago • 1 comments

Hi! regarding the part of signing in to github and dotfiles. I just discovered that the name and email, specified in the "gitconfig" is being used to sign commits, even in public repos. Would it be considered a useful warning for people to know that the full name and this email might be shown publicly at some point? if they create or contribute to a public repo, for example.

or also implement this posibility? https://stackoverflow.com/questions/7372970/git-commit-with-no-email/71542189#71542189

When contributing to github, always use the anonymous noreply email address provided by github - which you can find here: https://github.com/settings/emails (have to tick "Keep my email addresses private" to see it).

gitconfig looking like this:

[user]
    name = Joe Blogs
    email = [email protected]

Laiagdla avatar Apr 17 '24 10:04 Laiagdla

Thanks for reporting.

Created a new issue in teachers so I can discuss with WebDev and Data Engineering track owners because this part is common to all three setups.

julesvanrie avatar Apr 22 '24 12:04 julesvanrie

Fixed by https://github.com/lewagon/setup/pull/467

ssaunier avatar May 31 '24 15:05 ssaunier

This was still to do for DS, but I just did it.

This notice is in the dotfiles part and that is a separate partial for DS <> web (catering for case where the student did web bootcamp before).

julesvanrie avatar May 31 '24 18:05 julesvanrie

Sorry I forgot about the other repo, thanks for getting on it so quick! 🙏

ssaunier avatar May 31 '24 18:05 ssaunier