website icon indicating copy to clipboard operation
website copied to clipboard

Add sinhala (si) language

Open sayuri-gi opened this issue 4 years ago • 14 comments

This is a request to add sinhala (si) language for below projects.

https://crowdin.com/project/letest https://crowdin.com/project/lets-encrypt-website

It seems no additional details required for the first project and for 2nd project, TRANSLATION.md

  • https://github.com/letsencrypt/website/blob/master/config/_default/languages.en.toml

  • https://github.com/letsencrypt/website/blob/master/config/_default/menu.en.toml

[[main]]
name = "උදව් ගන්න"
weight = 20
url = "https://community.letsencrypt.org/"
[[main]]
name = "පරිත්‍යාග"
weight = 30
identifier = "donate"
url = "/si/donate/"
[[main]]
name = "අප ගැන"
weight = 40
identifier = "about"
url = "/si/about/"
[[main]]
name = "අන්තර්ජාල ආරක්ෂණ පර්යේෂණ සමූහය (අයි.එස්.ආර්.ජී.)"
weight = 20
identifier = "isrg"
parent = "about"
url = "https://www.abetterinternet.org/about/"
[[main]]
name = "සේවාවේ තත්වය"
weight = 60
identifier = "status"
parent = "about"
url = "https://letsencrypt.status.io/"
[[main]]
name = "වෘත්තීන්"
weight = 80
identifier = "careers"
parent = "about"
url = "https://www.abetterinternet.org/careers/"

Please consider to set https://crowdin.com/profile/helabasa as a proofreader for sinhala language (also the proofreader for lineageos, SuiteCRM, MXPlayer, mastodon etc) https://github.com/letsencrypt/website/issues/1061 @tdelmas @bdaehlie

sayuri-gi avatar Sep 03 '21 01:09 sayuri-gi

Thank you for your contribution!

When a few pages will be 100% translated on Crowdin https://crowdin.com/project/lets-encrypt-website/si-LK (if possible, including pages like about and how-it-works) I will open the Pull-request to add that language. Feel free to ping here or ask any question.

For the description, you said "or", can you help us to decide?

tdelmas avatar Nov 01 '21 10:11 tdelmas

When a few pages will be 100% translated on Crowdin https://crowdin.com/project/lets-encrypt-website/si-LK (if possible, including pages like about and how-it-works) I will open the Pull-request to add that language.

7 pages completed

For the description, you said "or", can you help us to decide?

Sure. it's only about Let's Encrypt. the difference is, one written in english and another in sinhala. Many companies (including foreign companies promote their business in our country) usually print or share their product, brand, company names using sinhala script to target customers, make their brand more memorable, bind to people's day-to-day life etc and otherhand this language has 21 vowels, clearly visible vowel signs also consider as a beautiful script and we see a success of it but that's strange for others; in this case, both options provided above

sayuri-gi avatar Nov 06 '21 17:11 sayuri-gi

Thank you for the explanation. I think it's better to keep "Let's Encrypt", because most other websites will be in English with that name.

And thank you for the translations on Crowdin, I'll create the first pull request to add Sinhala.

tdelmas avatar Nov 06 '21 18:11 tdelmas

Thank you again for your contribution. I've created the Pull Request:

  • https://github.com/letsencrypt/website/pull/1344

You can see the preview there : https://deploy-preview-1344--letsencrypt.netlify.app/si/

The only thing missing is the translation of that language file on Crowdin https://crowdin.com/translate/lets-encrypt-website/90/en-silk?filter=basic&value=0

Do you think you could help with that?

Once it is fully translated on Crowdin, I'll update the PR, so it could be merged.

tdelmas avatar Nov 07 '21 10:11 tdelmas

Do you think you could help with that?

Done. When we have enough time to spend, we'll try to complete the rest soon.

sayuri-gi avatar Nov 07 '21 15:11 sayuri-gi

Thank you very much for your contribution!

One (hopefully) last quick thing: how to translate "View in Sinhala" ?

tdelmas avatar Nov 07 '21 15:11 tdelmas

One (hopefully) last quick thing: how to translate "View in Sinhala" ?

සිංහලෙන් දකින්න

Minor fix: two strings updated, please fetch from crowdin before deploy

sayuri-gi avatar Nov 08 '21 20:11 sayuri-gi

How does the date get localized on website?

image

sayuri-gi avatar Nov 08 '21 21:11 sayuri-gi

@sayuri-gi Thank you for the update!

About the dates, they are localized using Hugo: https://gohugo.io/news/0.87.0-relnotes/ . Is their localization incorrect?

tdelmas avatar Nov 08 '21 22:11 tdelmas

About the dates, they are localized using Hugo: https://gohugo.io/news/0.87.0-relnotes/ . Is their localization incorrect?

Yes but it is external resource so you can ignore and finish this task^^ i will fix it soon

sayuri-gi avatar Nov 09 '21 14:11 sayuri-gi

@sayuri-gi Thank you, do not hesitate to mention here the relevant issue(s) or PR(s) in the Hugo's project.

The preview has been updated: https://deploy-preview-1344--letsencrypt.netlify.app/si/

Once a few more pages are translated, it can be merged. Ideally, "getting started" and "client options"!

The pages translated after that will be integrated regularly.

Also, for the page https://deploy-preview-1344--letsencrypt.netlify.app/si/stats/ some translations (like the graph controls) came from https://github.com/plotly/plotly.js/tree/master/dist but they don't have yet a translation for Sinhala (so the controls will be in English).

tdelmas avatar Nov 10 '21 20:11 tdelmas

Also, for the page https://deploy-preview-1344--letsencrypt.netlify.app/si/stats/ some translations (like the graph controls) came from https://github.com/plotly/plotly.js/tree/master/dist but they don't have yet a translation for Sinhala (so the controls will be in English).

https://github.com/plotly/plotly.js/pull/6238

sayuri-gi avatar Jun 16 '22 20:06 sayuri-gi

@sayuri-gi Thank you for the PR in plotly. It was merged, but the translation file is not (yet) there: https://github.com/plotly/plotly.js/tree/master/dist

When they build the next version, it should be available.

tdelmas avatar Jul 14 '22 10:07 tdelmas

Plotly did a release, so I updated the PR. https://github.com/letsencrypt/website/pull/1344/commits/14b7c7bedfb03394bfd5cb5d7c96eb99c606e149

tdelmas avatar Jul 15 '22 16:07 tdelmas