boulder icon indicating copy to clipboard operation
boulder copied to clipboard

Upgrade zlint from v3.6.0 to v3.6.2

Open pgporada opened this issue 1 year ago • 3 comments

Adds a few new lints (largely related to the Profiles ballot and recent CA incidents), two of which we need to disable:

  • e_cab_dv_subject_invalid_values fails with a Warning because we include a Common Name in most of our certificates. We already ignore w_subject_common_name_included, so this is a similar situation.

  • w_ext_subject_key_identifier_not_recommended_subscriber fails with a Warning because we include the SKID extension in all of our certificates. We intend to remove this extension in our upcoming "modernized" certificate profile.

DO NOT MERGE until IN-10466 is complete

pgporada avatar Jul 12 '24 18:07 pgporada

@pgporada, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

github-actions[bot] avatar Jul 12 '24 18:07 github-actions[bot]

SRE ticket filed, IN-10466

pgporada avatar Jul 12 '24 19:07 pgporada

It's worth noting that e_cab_dv_subject_invalid_values contains multiple checks, only one of which we violate. Skipping this lint is somewhat risky, if zlint decides to remove other individual lints which check for things like the Country field.

This is also a good prompt to consider removing the SKID from our end-entity certificates. I don't believe anyone is relying on it, and would be some good bytes to shed. (See https://github.com/letsencrypt/boulder/issues/7446.)

Finally, we may want to consider having different sets of lints for different issuance profiles, so that a "modern" profile which excludes the Common Name can be more strictly checked.

aarongable avatar Jul 17 '24 18:07 aarongable

It's worth noting that e_cab_dv_subject_invalid_values contains multiple checks, only one of which we violate. Skipping this lint is somewhat risky, if zlint decides to remove other individual lints which check for things like the Country field.

The unhelpful warning was removed in https://github.com/zmap/zlint/commit/068ae82324696a6f484be9baa6085318e7851112 So you could also upgrade or 3.6.3 or 3.6.4 instead of skipping that lint.

mathewhodson avatar Nov 01 '24 17:11 mathewhodson

SRE ticket is complete/deployed, so this is un-blocked in Production.

ezekiel avatar Dec 04 '24 21:12 ezekiel

Superseded by https://github.com/letsencrypt/boulder/pull/7897

aarongable avatar Dec 18 '24 00:12 aarongable