wpfui icon indicating copy to clipboard operation
wpfui copied to clipboard

Added the HorizontalIconAlignment property to the button.

Open m0lDaViA opened this issue 1 year ago • 6 comments

Added the HorizontalIconAlignment property to the button. You can now choose, if you want to show the icon left or right to the content.

Pull request type

Please check the type of change your PR introduces:

  • [x] Update
  • [x] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [x] Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

m0lDaViA avatar Jun 10 '24 08:06 m0lDaViA

Hm, the word "alignment" usually sounds like it is placed inside of a space. Like: text on a page is aligned inside/between the borders of the page. Not next to the page. Here, is more like a position relative to something else.

Jay-o-Way avatar Jun 11 '24 01:06 Jay-o-Way

Hm, the word "alignment" usually should like it is placed inside of a space. Like: text on a page is aligned inside/between the borders of the page. Not next to the page. Here, is more like a position relative to something else.

But it isn't relative, that's the difference.

m0lDaViA avatar Jun 12 '24 09:06 m0lDaViA

What I mean is, the icon is placed to the left/right of the content/text. Therefore I think "HorizontalIconPlacement" would be a good (or even more accurate) wording.

By the way, I assume this works well in RTL language?

Jay-o-Way avatar Jun 12 '24 10:06 Jay-o-Way

What I mean is, the icon is placed to the left/right of the content/text. Therefore I think "HorizontalIconPlacement" would be a good (or even more accurate) wording.

By the way, I assume this works well in RTL language?

In this case I followed the standard alignment that MS uses.

m0lDaViA avatar Jun 15 '24 15:06 m0lDaViA

#1120 & #887 can check the last commit.

m0lDaViA avatar Jun 21 '24 01:06 m0lDaViA

I don't know why, but my vs is bugged rn. I cannot create visible styles and my formatter does instead of formatting only opened files all .xaml files. Sorry for that.

m0lDaViA avatar Jun 26 '24 16:06 m0lDaViA