nodecloud icon indicating copy to clipboard operation
nodecloud copied to clipboard

Codacy changes

Open rajikaimal opened this issue 6 years ago • 1 comments

Take Codacy suggestions into account and make necessary changes to improve the code quality.

rajikaimal avatar Mar 19 '19 18:03 rajikaimal

I am currently working on adding Codacy suggestions. I would like to know some details regarding this @rajikaimal .

  • Codacy was showing some suggestions under the category of Error Prone which I assume that the console logs were added to display the output of this example or to display an error message. E.g. - Capture Do we need to remove these console logs?

  • I have corrected all code style suggestions on JavaScript.

  • I have formatted the readme file using a markdown plugin since codacy was showing some formatting issues with readme file.

  • I also assumed that the security issue by using a Found non-literal argument in require in this scenario should be ignored const ncConfig = require(path.join(process.cwd(), ".nc.config")); Capture

I would like to make any changes according to your suggestions regarding this PR @rajikaimal

rajitha1998 avatar Jan 06 '20 19:01 rajitha1998