nodecloud icon indicating copy to clipboard operation
nodecloud copied to clipboard

Refactoring the index.js file of AWS and GCP plugin by renaming the parameter

Open Shofiya2003 opened this issue 2 years ago • 1 comments

We are passing in the configuration details to the plugin from the ncConfig file via the common package https://github.com/leopardslab/nodecloud/blob/c8597192259598cbb90261b75ccb8aaf209deb78/packages/common/core/base-provider.js#L58

here the parameter for taking the configuration details from the ncConfig file is named options. https://github.com/leopardslab/nodecloud/blob/c8597192259598cbb90261b75ccb8aaf209deb78/packages/aws-plugin/index.js#L4

Similarly, the GCP plugin is also taking in the configuration details as a parameter named options. https://github.com/leopardslab/nodecloud/blob/c8597192259598cbb90261b75ccb8aaf209deb78/packages/gcp-plugin/index.js#L13

It would be easy to understand if we rename the options as configuration details

Shofiya2003 avatar Mar 11 '23 14:03 Shofiya2003

@mbcse @rajitha1998 Can we do something like this?

Shofiya2003 avatar Mar 11 '23 14:03 Shofiya2003