stable-diffusion.cpp icon indicating copy to clipboard operation
stable-diffusion.cpp copied to clipboard

Break pseudo token

Open daniandtheweb opened this issue 1 year ago • 1 comments

I've noticed that #285 hasn't been updated for a while so I've upstreamed the PR and fixed the regex to correctly identify the BREAK token without deleting the white spaces. @ursg I've still marked you as the author as most of the work was yours, if you still want to update your PR instead I'll close this.

daniandtheweb avatar Sep 27 '24 18:09 daniandtheweb

So THAT'S how you deal with color bleed! Good to know, and do want!

lostdisc avatar Jan 10 '25 16:01 lostdisc

That 'B' stuff on the regex took me a bit too long to understand, so a comment would've been appreciated 🙂 Apart from that, the code looks good to me, and worked as expected on a few tests.

wbruna avatar Jun 19 '25 19:06 wbruna

Actually I should refactor this code to properly adapt it to the master branch. Right now it's a bit messy. I'll still add the original author as coauthor.

daniandtheweb avatar Jun 19 '25 20:06 daniandtheweb

I've finally remembered that I had this PR pending. I've just upstreamed it and it seems to work nicely. @wbruna I added a comment on what does B do for easier understanding, let me know if it seems clear enough, I'm not really good at explaining regex.

daniandtheweb avatar Oct 15 '25 18:10 daniandtheweb

Thank you for your contribution.

leejet avatar Nov 16 '25 06:11 leejet