lean4 icon indicating copy to clipboard operation
lean4 copied to clipboard

feat: make `registerLabelAttr` consistent with `registerTagAttribute`

Open thorimur opened this issue 1 year ago • 4 comments

This PR modifies the recently-upstreamed LabelAttributes to be consistent with TagAttributes. Specifically, we modify registerLabelAttr to

  • allow a validate argument
  • allow an AttributeApplicationTime argument
  • change the default applicationTime to .afterTypeChecking
  • use the same argument order as registerTagAttribute

This also modifies some docstrings to point users to these features.

thorimur avatar Mar 16 '24 21:03 thorimur

Mathlib CI status (docs):

Just confirming that this is still a draft. The changes do seem nice to have!

kim-em avatar May 10 '24 07:05 kim-em

@semorrison Apologies, I've been inactive for the past few months! :) If this is still desired I'm happy to finalize it and make it a real PR.

thorimur avatar Sep 13 '24 22:09 thorimur