mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(AlgebraicGeometry/EllipticCurve/Jacobian): implement group operations on nonsingular rational points for Jacobian coordinates

Open Multramate opened this issue 2 years ago • 1 comments

Define a addition-preserving bijection toAffine_addEquiv with the affine case to prove Point is an abelian group.

This is the fourth in a series of four PRs leading to #9405 and is analogous to #9420


  • [ ] depends on: #9432
  • [ ] depends on: #9433
  • [ ] depends on: #9435
  • [ ] depends on: #13060

Open in Gitpod

Multramate avatar Jan 04 '24 10:01 Multramate

This PR/issue depends on:

  • ~~leanprover-community/mathlib4#9432~~
  • ~~leanprover-community/mathlib4#9433~~
  • ~~leanprover-community/mathlib4#9435~~
  • ~~leanprover-community/mathlib4#13060~~ By Dependent Issues (🤖). Happy coding!

Seems we need to add Jacobian.lean to style-exceptions (see here), or compress it (e.g. lemmas that fit in a single line, and blanks between such lemmas), or split it up.

alreadydone avatar Jun 07 '24 16:06 alreadydone

PR summary

Import changes

No significant changes to the import graph


Declarations diff

+ Point + X_eq_iff + Y_eq_iff + Y_eq_iff' + add + add_def + add_of_imp + add_point + fromAffine + fromAffine_some + fromAffine_zero + instAddPoint + instNegPoint + instZeroPoint + mk_point + neg + neg_def + neg_point + toAffine + toAffineAddEquiv + toAffineLift + toAffineLift_add + toAffineLift_eq + toAffineLift_neg + toAffineLift_of_Z_eq_zero + toAffineLift_of_Z_ne_zero + toAffineLift_some + toAffineLift_zero + toAffine_add + toAffine_neg + toAffine_of_Z_eq_zero + toAffine_of_Z_ne_zero + toAffine_of_equiv + toAffine_of_singular + toAffine_smul + toAffine_some + toAffine_zero + zero_def + zero_point

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

github-actions[bot] avatar Jun 09 '24 12:06 github-actions[bot]

Thanks 🎉 maintainer merge

alreadydone avatar Jun 09 '24 19:06 alreadydone

🚀 Pull request has been placed on the maintainer queue by alreadydone.

github-actions[bot] avatar Jun 09 '24 19:06 github-actions[bot]

Thanks!

bors merge

joelriou avatar Jun 10 '24 10:06 joelriou

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jun 10 '24 11:06 mathlib-bors[bot]