mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

chore(Algebra/Order): deduplicate material on ordered algebras

Open artie2000 opened this issue 1 month ago • 6 comments


Open in Gitpod

artie2000 avatar Dec 16 '25 02:12 artie2000

PR summary 0a5fe12b77

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Order.Algebra 299 300 +1 (+0.33%)
Mathlib.Algebra.Order.Module.Algebra 300 301 +1 (+0.33%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Order.Algebra Mathlib.Algebra.Order.Module.Algebra 1

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

github-actions[bot] avatar Dec 16 '25 02:12 github-actions[bot]

In my real closed field repo, I had defined ordered algebras because I couldn't find them in Mathlib. Today I found out they have been "defined" in Mathlib not once but twice, 3 years apart and apparently completely independently. How can we improve discoverability of this slightly counter-intuitive formalisation?

artie2000 avatar Dec 16 '25 02:12 artie2000

Moving it to Algebra.Order.Algebra would help

OK, I will switch the module deprecation.

artie2000 avatar Dec 16 '25 10:12 artie2000

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

github-actions[bot] avatar Dec 17 '25 20:12 github-actions[bot]

Thanks :tada:

bors merge

jcommelin avatar Dec 18 '25 08:12 jcommelin

Build failed:

mathlib-bors[bot] avatar Dec 18 '25 08:12 mathlib-bors[bot]

@jcommelin fixed

artie2000 avatar Dec 18 '25 13:12 artie2000

maintainer merge

YaelDillies avatar Dec 18 '25 14:12 YaelDillies

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

github-actions[bot] avatar Dec 18 '25 14:12 github-actions[bot]

Spurious CI failure

artie2000 avatar Dec 18 '25 15:12 artie2000

Thanks :tada:

bors merge

jcommelin avatar Dec 18 '25 16:12 jcommelin

Hijacking this PR to run a quick test for #33042. Please ignore! maintainer merge?

bryangingechen avatar Dec 18 '25 16:12 bryangingechen

🚀 Pull request has been placed on the maintainer queue by bryangingechen.

github-actions[bot] avatar Dec 18 '25 16:12 github-actions[bot]

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Dec 18 '25 16:12 mathlib-bors[bot]