mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(Algebra): forgetful lemmas for `map` and `comap` on substructures

Open artie2000 opened this issue 1 month ago • 2 comments

  • Standardise the form of forgetful lemmas for map and comap (ie, (co)map_toSubfoo)
  • Add missing lemmas of this form
  • Mark all such lemmas as simp

  • [ ] depends on: #21031

Open in Gitpod

artie2000 avatar Dec 15 '25 04:12 artie2000

PR summary 3ea6690c34

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ comap_toAddSubgroup + comap_toNonUnitalSubsemiring + comap_toSubalgebra + comap_toSubsemiring + map_toAddSubmonoid + map_toSubmonoid + map_toSubsemiring ++ comap_toAddSubmonoid ++ comap_toSubmodule -++ comap_toSubmonoid

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

github-actions[bot] avatar Dec 15 '25 04:12 github-actions[bot]

This PR/issue depends on: