mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

refactor(RingTheory/Ideal/Pointwise): Make `Ideal.IsPrime.smul` into an instance

Open tb65536 opened this issue 1 year ago • 1 comments

This PR makes Ideal.IsPrime.smul into an instance (like how Ideal.IsPrime.comap is an instance).


Open in Gitpod

tb65536 avatar Oct 26 '24 00:10 tb65536

PR summary fcc7fe288b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

github-actions[bot] avatar Oct 26 '24 00:10 github-actions[bot]

!bench

riccardobrasca avatar Nov 07 '24 11:11 riccardobrasca

Here are the benchmark results for commit 075fe7eca3ab7f44ea1162d8e184071ffcae929c. There were significant changes against commit cd1f49389b69f1e427def7a7c0ddc46f6a7da7dd:

  Benchmark      Metric                 Change
  =====================================================
- build          .olean serialization     9.6%
- build          import                  11.1%
- build          initialization           8.4%
- open Mathlib   task-clock              15.8% (16.3 σ)

leanprover-bot avatar Nov 07 '24 11:11 leanprover-bot

Can you please merge master and see if bench gives the same results?

riccardobrasca avatar Nov 07 '24 12:11 riccardobrasca

!bench

tb65536 avatar Nov 07 '24 16:11 tb65536

Here are the benchmark results for commit fcc7fe288b254fa5f169545fa11e02ed254fe917. There were no significant changes against commit b14fe2c87e1a03a66514f49dc1f50d1c06f5e74d.

leanprover-bot avatar Nov 07 '24 16:11 leanprover-bot

Thanks+

bors merge

riccardobrasca avatar Nov 07 '24 17:11 riccardobrasca

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Nov 07 '24 17:11 mathlib-bors[bot]