mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(Algebra): define `PrimitiveIdempotents`

Open Whysoserioushah opened this issue 1 year ago • 1 comments

Co-authored-by : @jjaassoonn


Open in Gitpod

Whysoserioushah avatar Oct 24 '24 18:10 Whysoserioushah

PR summary 63dcdd9437

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.DirectSum.Idempotents (new file) 1092

Declarations diff

+ completeOrthogonalIdempotents_idempotent + decompose_eq_mul_idempotent + idempotent + isIdempotentElem_idempotent

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

github-actions[bot] avatar Oct 24 '24 18:10 github-actions[bot]

And I think (also judging from the "large-import" tag) this belongs to Mathlib.Algebra.DirectSum.Idempotents or something similar.

Also please update the PR title so that it matches with the content.

erdOne avatar Dec 31 '24 15:12 erdOne

Thanks a lot!

bors d+

kbuzzard avatar Jan 04 '25 18:01 kbuzzard

:v: Whysoserioushah can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors[bot] avatar Jan 04 '25 18:01 mathlib-bors[bot]

bors r+

Whysoserioushah avatar Jan 04 '25 18:01 Whysoserioushah

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jan 04 '25 19:01 mathlib-bors[bot]